-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.inputs_for
component
#2411
Merged
chrismccord
merged 5 commits into
phoenixframework:master
from
LostKobrakai:pr/inputs-for-component
Feb 10, 2023
Merged
.inputs_for
component
#2411
chrismccord
merged 5 commits into
phoenixframework:master
from
LostKobrakai:pr/inputs-for-component
Feb 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LostKobrakai
commented
Jan 21, 2023
josevalim
reviewed
Jan 21, 2023
LostKobrakai
force-pushed
the
pr/inputs-for-component
branch
from
January 21, 2023 21:22
64078e8
to
38335ef
Compare
josevalim
reviewed
Jan 21, 2023
josevalim
reviewed
Jan 21, 2023
josevalim
reviewed
Jan 21, 2023
LostKobrakai
force-pushed
the
pr/inputs-for-component
branch
from
January 21, 2023 21:56
9b392eb
to
4fed52e
Compare
❤️❤️❤️🐥🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending decisions from #2410:
The
field={f, field}
is only in new apps and we don't use this pattern in LV yetUnsure if it should be called inputs_for given it is no longer form_for (although there benefits to sticking with the name)